(hoping this threads as a reply. t-bird doesnt get a copy from gmail)
I plan to attach my patches, since this list seems ok w that practice.
If thats inconvenient, pls let me know, Im happy to accommodate a
reviewer :-)
And this one doesnt need it (I hope)
the top section is throwaway comments by convention, right ?
and below is for the changelog?
---
Clean up whitespace, and remove editor format-control comment-blocks.
Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
$ diffstat patch.preclean
arch/i386/kernel/scx200.c | 7 -------
drivers/char/scx200_gpio.c | 32 ++++++++++++--------------------
include/linux/scx200.h | 7 -------
include/linux/scx200_gpio.h | 7 -------
4 files changed, 12 insertions(+), 41 deletions(-)
---
diff -ruNp -X dontdiff -X exclude-diffs ab-0/arch/i386/kernel/scx200.c ab-1/arch/i386/kernel/scx200.c
--- ab-0/arch/i386/kernel/scx200.c 2006-03-19 22:53:29.000000000 -0700
+++ ab-1/arch/i386/kernel/scx200.c 2006-06-02 13:35:17.000000000 -0600
@@ -159,10 +159,3 @@ EXPORT_SYMBOL(scx200_gpio_base);
EXPORT_SYMBOL(scx200_gpio_shadow);
EXPORT_SYMBOL(scx200_gpio_configure);
EXPORT_SYMBOL(scx200_cb_base);
-
-/*
- Local variables:
- compile-command: "make -k -C ../../.. SUBDIRS=arch/i386/kernel modules"
- c-basic-offset: 8
- End:
-*/
diff -ruNp -X dontdiff -X exclude-diffs ab-0/drivers/char/scx200_gpio.c ab-1/drivers/char/scx200_gpio.c
--- ab-0/drivers/char/scx200_gpio.c 2006-03-19 22:53:29.000000000 -0700
+++ ab-1/drivers/char/scx200_gpio.c 2006-06-02 13:35:17.000000000 -0600
@@ -1,4 +1,4 @@
-/* linux/drivers/char/scx200_gpio.c
+/* linux/drivers/char/scx200_gpio.c
National Semiconductor SCx200 GPIO driver. Allows a user space
process to play with the GPIO pins.
@@ -26,23 +26,22 @@ static int major = 0; /* default to dyn
module_param(major, int, 0);
MODULE_PARM_DESC(major, "Major device number");
-static ssize_t scx200_gpio_write(struct file *file, const char __user *data,
- size_t len, loff_t *ppos)
+static ssize_t scx200_gpio_write(struct file *file, const char __user * data,
+ size_t len, loff_t * ppos)
{
unsigned m = iminor(file->f_dentry->d_inode);
size_t i;
for (i = 0; i < len; ++i) {
char c;
- if (get_user(c, data+i))
+ if (get_user(c, data + i))
return -EFAULT;
- switch (c)
- {
- case '0':
- scx200_gpio_set(m, 0);
+ switch (c) {
+ case '0':
+ scx200_gpio_set(m, 0);
break;
- case '1':
- scx200_gpio_set(m, 1);
+ case '1':
+ scx200_gpio_set(m, 1);
break;
case 'O':
printk(KERN_INFO NAME ": GPIO%d output enabled\n", m);
@@ -74,8 +73,8 @@ static ssize_t scx200_gpio_write(struct
return len;
}
-static ssize_t scx200_gpio_read(struct file *file, char __user *buf,
- size_t len, loff_t *ppos)
+static ssize_t scx200_gpio_read(struct file *file, char __user * buf,
+ size_t len, loff_t * ppos)
{
unsigned m = iminor(file->f_dentry->d_inode);
int value;
@@ -83,7 +82,7 @@ static ssize_t scx200_gpio_read(struct f
value = scx200_gpio_get(m);
if (put_user(value ? '1' : '0', buf))
return -EFAULT;
-
+
return 1;
}
@@ -140,10 +139,3 @@ static void __exit scx200_gpio_cleanup(v
module_init(scx200_gpio_init);
module_exit(scx200_gpio_cleanup);
-
-/*
- Local variables:
- compile-command: "make -k -C ../.. SUBDIRS=drivers/char modules"
- c-basic-offset: 8
- End:
-*/
diff -ruNp -X dontdiff -X exclude-diffs ab-0/include/linux/scx200_gpio.h ab-1/include/linux/scx200_gpio.h
--- ab-0/include/linux/scx200_gpio.h 2006-03-19 22:53:29.000000000 -0700
+++ ab-1/include/linux/scx200_gpio.h 2006-06-02 13:35:17.000000000 -0600
@@ -87,10 +87,3 @@ static inline void scx200_gpio_change(in
#undef __SCx200_GPIO_SHADOW
#undef __SCx200_GPIO_INDEX
#undef __SCx200_GPIO_OUT
-
-/*
- Local variables:
- compile-command: "make -C ../.. bzImage modules"
- c-basic-offset: 8
- End:
-*/
diff -ruNp -X dontdiff -X exclude-diffs ab-0/include/linux/scx200.h ab-1/include/linux/scx200.h
--- ab-0/include/linux/scx200.h 2006-03-19 22:53:29.000000000 -0700
+++ ab-1/include/linux/scx200.h 2006-06-02 13:35:17.000000000 -0600
@@ -49,10 +49,3 @@ extern unsigned scx200_cb_base;
#define SCx200_REV 0x3d /* Revision Register */
#define SCx200_CBA 0x3e /* Configuration Base Address Register */
#define SCx200_CBA_SCRATCH 0x64 /* Configuration Base Address Scratchpad */
-
-/*
- Local variables:
- compile-command: "make -C ../.. bzImage modules"
- c-basic-offset: 8
- End:
-*/
