On Wed, 27 Apr 2011, Mr Dash Four wrote: > > > Due to the restarting bug (add the first element again) and failing as it > > > is already added, the resizing happened once. > > OK, I'll wait for this to be fixed then. > I ran into more problems, unfortunately! > > This is what I executed after managing to use the same ipset revisions in both > the kernel and userspace: > > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -L test > Name: test > Type: hash:net,port > Header: family inet hashsize 1024 maxelem 65536 > Size in memory: 16760 > References: 0 > Members: > > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4096 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -terse -L test > Name: test > Type: hash:net,port > Header: family inet hashsize 2048 maxelem 65536 > Size in memory: 91448 > References: 0 > > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-6144 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -terse -L test > Name: test > Type: hash:net,port > Header: family inet hashsize 2048 maxelem 65536 > Size in memory: 33144 > References: 0 > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-5120 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4608 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4096 > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4352 > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4224 > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4480 > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4544 > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4607 > > [root@test1 ~]# ipset -F test > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4608 > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4608 > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4864 > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-5120 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-5120 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4864 > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-5119 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-5056 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4865 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4864 > ipset v6.4: Element cannot be added to the set: it's already added > > [root@test1 ~]# ipset -X test > [root@test1 ~]# ipset -N test hash:net,port > [root@test1 ~]# ipset -A test 10.4.0.0/14,1-4864 > ipset v6.4: Element cannot be added to the set: it's already added > > As evident from the above, there seem to be some, quite frankly, bizarre > results: > > 1. Even though the maxelem value is 64k I seems to be restricted to add the > amount of elements in the set which do not require the hash value to more than > double (that may be related to the previous bug with hash:ip set though). This is the same bug you discovered last time: the internal restarting at adding elements after resizing fails. Please note, the maxelem parameter has no effect, but the hashsize does: if the hash too small, it has to be resized. > 2. Take a note when I try to add 4608 elements to the test set - I did that 3 > times with completely different results - it seems that ipset triggers an > error when it feels like it. The hashes are created with a random hash key calculation parameter: if the hash is lucky enough, you can stuff the data into it without reaching the clashing limit and without the need to resize the hash. > 3. Following on from the previous point, when I try to add more elements than > the established "error threshold" in point 2 above, I also get mixed results > (attempting to add 4864 elements gives me 2 successes and 2 failures after 4 > attempts made when I re-created the test set from scratch). The same as above: if the clash limit is not reached, the hash happily can accept more data. If it's reached, resizing is triggered which is successfully done, but adding elements starts again with the already added element. That needs to be fixed. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
