On Friday 10 October 2003 15:00, David S. Miller wrote: > Ingo Oeser <ioe-lkml@xxxxxxxxxx> wrote: > > Would you mind __attribute_nonnull__ for these functions, if we > > enable GCC 3.3 support for this[1]? > > I would say yes, but why? All this attribute does is optimize > away tests for NULL which surprise surprise we don't have any > of in kfree_skb(). And it wouldn't warn about passing NULL to these functions? That's bad... But maybe sparse/smatch are better for this...
