On Fri, 10 Oct 2003 14:53:44 +0200 Ingo Oeser <ioe-lkml@xxxxxxxxxx> wrote: > On Wednesday 08 October 2003 15:47, David S. Miller wrote: > > On Wed, 08 Oct 2003 09:09:48 -0400 > > > > Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > > > I would prefer that you fix your code instead, to not pass NULL to > > > kfree_skb()... > > > > Absolutely, there is no valid reason to pass NULL into these > > routines. > > Would you mind __attribute_nonnull__ for these functions, if we > enable GCC 3.3 support for this[1]? I would say yes, but why? All this attribute does is optimize away tests for NULL which surprise surprise we don't have any of in kfree_skb().
