On Thu, Mar 13, 2025 at 07:01:38PM +0100, Eric Woudstra wrote: > > > On 3/13/25 12:11 AM, Pablo Neira Ayuso wrote: > > >> What do you suggest? > > > > Probably I can collect 4/15 and 5/15 from this series to be included > > in the next pull request, let me take a look. But it would be good to > > have tests for these two patches. > > > > These are not most important to bridge-fastpath, but it gives extra > possibilities. How about concentrating first on patch 2/15 (with 1/15 > removing a warning and 3/15 cleaning up), adding nf_flow_encap_push() > for xmit direct? It is a vital patch for the bridge-fastpath. I see cleanup patch 3/15 is a consequence of 2/15, let me take a look. > Anyway, I will look into writing selftests for conntrack-bridge setup, > including various vlan setups. This will take me some time, which I > do not have in abundance, so for that I do not know if I get it done > before the merge window. There is tools/testing/selftests/net/netfilter/nft_flowtable.sh that can possibly be extended to improve coverage. Thanks.
