On Thu, Nov 02, 2023 at 04:29:34PM +0100, Thomas Haller wrote:
> On Thu, 2023-11-02 at 16:03 +0100, Phil Sutter wrote:
> >
> > +# Note: Element expiry is no longer reset since kernel commit
> > 4c90bba60c26
> > +# ("netfilter: nf_tables: do not refresh timeout when resetting
> > element"),
> > +# the respective parts of the test have therefore been commented
> > out.
>
> Hi Phil,
>
> do you expect that the old behavior ever comes back?
A recent nfbz comment[1] from Pablo made me doubt the decision is final,
though I may have misread it.
> Why keep the old checks (commented out)? Maybe drop them? We can get it
> from git history.
Should the change be permanent, one should change the tests to assert
the opposite, namely that expires values are unaffected by the reset.
> If you think something is still unclear without them, then instead
> elaborate further in the code comment (thanks for adding a code comment
> in the first place, very useful).
Cheers, Phil
