Re: [nft PATCH] tests: shell: Fix sets/reset_command_0 for current kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2023-11-02 at 16:03 +0100, Phil Sutter wrote:
>  
> +# Note: Element expiry is no longer reset since kernel commit
> 4c90bba60c26
> +# ("netfilter: nf_tables: do not refresh timeout when resetting
> element"),
> +# the respective parts of the test have therefore been commented
> out.

Hi Phil,

do you expect that the old behavior ever comes back?

Why keep the old checks (commented out)? Maybe drop them? We can get it
from git history.

If you think something is still unclear without them, then instead
elaborate further in the code comment (thanks for adding a code comment
in the first place, very useful).


Thomas





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux