On Thu, Nov 02, 2023 at 04:58:43PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Nov 02, 2023 at 04:56:37PM +0100, Pablo Neira Ayuso wrote:
> > On Thu, Nov 02, 2023 at 02:52:58PM +0100, Phil Sutter wrote:
> [...]
> > > diff --git a/src/statement.c b/src/statement.c
> > > index 475611664946a..f5176e6d87f95 100644
> > > --- a/src/statement.c
> > > +++ b/src/statement.c
> > > @@ -989,7 +989,7 @@ static void tproxy_stmt_print(const struct stmt *stmt, struct output_ctx *octx)
> > > expr_print(stmt->tproxy.addr, octx);
> > > }
> > > }
> > > - if (stmt->tproxy.port && stmt->tproxy.port->etype == EXPR_VALUE) {
> > > + if (stmt->tproxy.port) {
>
> Question: is this pattern used elsewhere?
>
> The original author of this might have taken (copied) this code from
> an existing statement?
A quick grep for EXPR_VALUE didn't turn up anything suspicious.
Maybe Máté recalls why he did things this way back in 2018. FWIW, the
EXPR_VALUE check was already there in v1 of his patch.
Cheers, Phil
