On Wed, Apr 13, 2022 at 01:30:23AM +0200, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > Yes, but its like this also before my patch, there are several > > > test failures on s390 with nft master. > > > > Why is the listing being reordered? > > No idea, I only saw that this reordering happens, i did not have time to > investigate so far. > > > > I will have a look, so far I only checked that my patch > > > series does not cause any additional test failures, and the only > > > reason why the new test fails is the output reorder on s390. > > > > This is also related to the set description patchset that Phil posted, > > correct? > > No, I don't even know what patchset you are talking about. > Is it because of failing pything tests because the debug output has > endianess issues? If so, not related. > > > If you consider that adding remaining features is feasible, > > incrementally should be fine. > > Hmm, if there is a technical reason as to why it does not work, > do you think we should hold it back? > > It lookes like filter on "{ eth0, ppp* }" works fine as-is. Then, good. Better than not working. > I thought that something like "eth0-eth42" would also be doable, > by treating both as 128bit bit-string. > > Don't see what prevents "ppp* . 80" from working from a technical pov. > > So, I *think* its fine to add the pure ifname set support now and > add the rest incrementally. OK, then move on. Sorry, I read you cover letter and I thought there were pending issues.