Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Sat, Apr 09, 2022 at 03:58:23PM +0200, Florian Westphal wrote:
> > Allow to match something like
> >
> > meta iifname { eth0, ppp* }.
>
> This series LGTM, thanks for working on this.
>
> > Set ranges or concatenations are not yet supported.
> > Test passes on x86_64 and s390 (bigendian), however, the test fails dump
> > validation:
> >
> > - iifname { "eth0", "abcdef0" } counter packets 0 bytes 0
> > + iifname { "abcdef0", "eth0" } counter packets 0 bytes 0
>
> Hm. Is it reordering the listing?
Yes, but its like this also before my patch, there are several
test failures on s390 with nft master.
I will have a look, so far I only checked that my patch
series does not cause any additional test failures, and the only
reason why the new test fails is the output reorder on s390.
> > I wil try to get string range support working and will
> > then ook into concat set support.
>
> OK, so then this is a WIP?
If you want all at once then yes, but do you think thats needed?
I have not looked at EXPR_RANGE or concat-with-wildcard yet and
I don't know when I will be able to do so.
