On 1/25/22 8:25 PM, Jakub Kicinski wrote: > On Tue, 25 Jan 2022 20:04:39 -0700 David Ahern wrote: >>> I realized it, but SKB_DROP_REASON_TCP_FILTER was already >>> introduced before. Besides, I think maybe >> >> SKB_DROP_REASON_TCP_FILTER is not in a released kernel yet. If >> Dave/Jakub are ok you can change SKB_DROP_REASON_TCP_FILTER to >> SKB_DROP_REASON_SOCKET_FILTER in 'net' repository to make it usable in >> both code paths. > > SGTM, FWIW. > > What was the reason we went with separate CSUM values for TCP and UDP? > Should we coalesce those as well? To me those are good as independent reasons because the checksum is part of the protocol and visible in packets.