On Wed, Jan 26, 2022 at 10:25 AM David Ahern <dsahern@xxxxxxxxx> wrote:
>
> On 1/24/22 6:15 AM, menglong8.dong@xxxxxxxxx wrote:
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> > index 603f77ef2170..dd64a4f2ff1d 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -330,6 +330,7 @@ enum skb_drop_reason {
> > SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST,
> > SKB_DROP_REASON_XFRM_POLICY,
> > SKB_DROP_REASON_IP_NOPROTO,
> > + SKB_DROP_REASON_UDP_FILTER,
>
> Is there really a need for a UDP and TCP version? why not just:
>
> /* dropped due to bpf filter on socket */
> SKB_DROP_REASON_SOCKET_FILTER
>
I realized it, but SKB_DROP_REASON_TCP_FILTER was already
introduced before. Besides, I think maybe
a SKB_DROP_REASON_L4_CSUM is enough for UDP/TCP/ICMP
checksum error?
> > SKB_DROP_REASON_MAX,
> > };
> >
>
