On 1/25/22 7:43 PM, Menglong Dong wrote:
> On Wed, Jan 26, 2022 at 10:25 AM David Ahern <dsahern@xxxxxxxxx> wrote:
>>
>> On 1/24/22 6:15 AM, menglong8.dong@xxxxxxxxx wrote:
>>> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
>>> index 603f77ef2170..dd64a4f2ff1d 100644
>>> --- a/include/linux/skbuff.h
>>> +++ b/include/linux/skbuff.h
>>> @@ -330,6 +330,7 @@ enum skb_drop_reason {
>>> SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST,
>>> SKB_DROP_REASON_XFRM_POLICY,
>>> SKB_DROP_REASON_IP_NOPROTO,
>>> + SKB_DROP_REASON_UDP_FILTER,
>>
>> Is there really a need for a UDP and TCP version? why not just:
>>
>> /* dropped due to bpf filter on socket */
>> SKB_DROP_REASON_SOCKET_FILTER
>>
>
> I realized it, but SKB_DROP_REASON_TCP_FILTER was already
> introduced before. Besides, I think maybe
SKB_DROP_REASON_TCP_FILTER is not in a released kernel yet. If
Dave/Jakub are ok you can change SKB_DROP_REASON_TCP_FILTER to
SKB_DROP_REASON_SOCKET_FILTER in 'net' repository to make it usable in
both code paths.
> a SKB_DROP_REASON_L4_CSUM is enough for UDP/TCP/ICMP
> checksum error?
Separating this one has value to me since they are separate protocols.
