On Wed, Jan 26, 2022 at 10:57 AM David Ahern <dsahern@xxxxxxxxx> wrote: > > On 1/25/22 7:36 PM, Menglong Dong wrote: > > Is't it meaningful? I name it from the meaning of 'ip route lookup or validate > > failed in input path', can't it express this information? > > > ip_route_input_noref has many failures and not all of them are FIB > lookups. ip_route_input_slow has a bunch of EINVAL cases for example. > > Returning a 'reason' as the code function name has no meaning to a user > and could actually be misleading in some cases. I would skip this one > for now. Yeah, the real reason can be complex. I'll skip this case for now.