On Wed, Aug 25, 2021 at 08:08:38AM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 25, 2021 at 02:15:05PM +1000, Duncan Roe wrote: > > On Tue, Aug 24, 2021 at 12:30:52PM +0200, Pablo Neira Ayuso wrote: [...] > > > > Time to wrap up the whole lot in a single patch. > > > > v5 was going to remove the make distcheck cruft in doxygen/Makefile.am, > > which is adjacent to the now-removed embedded script. > > So now there is juat 1 big block of red. > > > > I reverted some non-essential changes in configure.ac to reduce the diff. > > > > The new patch will be titled "Fix man pages". > > At least two patches would be the best way to go for traceability: > > #1 Move code to script. > #2 Your updates > > The problem with code updates and moving code is that the diff patch > format is not very good at catching those together, since it makes it > look like code deleted plus new code. > > Thanks! So... starting from master, move out the shell script and add EXTRA_DIST for it. The script does change on being moved - un-double doubled-up $ signs, remove traling ";/" and so on. That'd be the first patch. Second patch could be upgrade shell script to latest. Third patch would be everything else, unless I can manage to extract the bit that fixes `make distcleancheck` then the rest would be a 4th patch. Would you accept that? Cheers ... Duncan.
