Re: [PATCH libnetfilter_queue v4 4/4] build: doc: split off shell script from within doxygen/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Aug 25, 2021 at 02:15:05PM +1000, Duncan Roe wrote:
> On Tue, Aug 24, 2021 at 12:30:52PM +0200, Pablo Neira Ayuso wrote:
> > On Sun, Aug 22, 2021 at 02:14:42PM +1000, Duncan Roe wrote:
> > > This time, Makefile obeys the script via its absolute source pathname rather
> > > than trying to force a copy into the build dir as we did previously.
> >
> > Could you make this in first place? As coming 1/x coming in this
> > series.
> >
> > Thanks.
> Time to wrap up the whole lot in a single patch.
> v5 was going to remove the make distcheck cruft in doxygen/, which is
> adjacent to the now-removed embedded script. So now there is juat 1 big block of
> red.
> I reverted some non-essential changes in to reduce the diff.
> The new patch will be titled "Fix man pages".

At least two patches would be the best way to go for traceability:

#1 Move code to script.
#2 Your updates

The problem with code updates and moving code is that the diff patch
format is not very good at catching those together, since it makes it
look like code deleted plus new code.


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux