Re: [PATCH] netfilter: Add MODULE_DESCRIPTION entries to kernel modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]
[also build test WARNING on v5.8-rc1 next-20200618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rob-Gill/netfilter-Add-MODULE_DESCRIPTION-entries-to-kernel-modules/20200620-161928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: x86_64-randconfig-s022-20200619 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-rc1-18-g27caae40-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> net/netfilter/nft_reject_inet.c:152:1: sparse: sparse: macro "MODULE_DESCRIPTION" passed 1 arguments, but takes just 1
   include/net/netfilter/ipv6/nf_reject.h:24:0: sparse: sparse: Expected ; at end of declaration
   include/net/netfilter/ipv6/nf_reject.h:24:0: sparse: sparse: got end-of-input

# https://github.com/0day-ci/linux/commit/fba1516ed2fd485dba31c169de71cccc5a98df77
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout fba1516ed2fd485dba31c169de71cccc5a98df77
vim +/MODULE_DESCRIPTION +152 net/netfilter/nft_reject_inet.c

05513e9e33dbde Patrick McHardy 2014-02-05  148  
05513e9e33dbde Patrick McHardy 2014-02-05  149  MODULE_LICENSE("GPL");
05513e9e33dbde Patrick McHardy 2014-02-05  150  MODULE_AUTHOR("Patrick McHardy <kaber@xxxxxxxxx>");
05513e9e33dbde Patrick McHardy 2014-02-05  151  MODULE_ALIAS_NFT_AF_EXPR(1, "reject");
fba1516ed2fd48 Rob Gill        2020-06-20 @152  MODULE_DESCRIPTION("Netfilter nf_tables reject inet support"

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux