From: Herbert Xu > On Mon, Jan 26, 2015 at 10:09:24AM +0000, David Laight wrote: > > > > That doesn't look right to me. > > Surely you shouldn't be calling rcu_read_lock() when the mutex > > request is interrupted. > > > > So maybe: > > err = mutex_lock_interruptible(&ht->mutex); > > if (err) > > return err; > > rcu_read_lock(); > > No, we need to grab the RCU read lock while holding the mutex > in order to prevent future resizes from happening once we release > the mutex. But if err is non-zero you don't hold the mutex. Presumably the calling code also errors out immediately, so the RCU lock isn't needed at all. David -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
