On 30.01, Herbert Xu wrote: > On Wed, Jan 28, 2015 at 07:07:16PM +0000, Patrick McHardy wrote: > > On 28.01, Herbert Xu wrote: > > > On Tue, Jan 27, 2015 at 01:09:50PM +0000, Patrick McHardy wrote: > > > > > > > > Actually I have a patchset queued that adds runtime additions and > > > > removals, both active and timeout based. So netfilter won't have > > > > pure synchronous behaviour anymore. > > > > > > Can you show us the patchset? > > > > Sure, will send it over tomorrow. > > So how are you handling the locking in these cases? Insertion is handled using the rhashtable internal locks. GC happens in work context and takes the rhashtable mutex, then walks the table similar to nft_hash_walk and removes stale entries. Still need to work out something to reduce RCU grace periods (currently ignored) and make sure we don't race between ->get/->remove in the netlink API and GC. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
