From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Date: Fri, 15 Nov 2013 14:23:14 +0100 > On Fri, 2013-11-15 at 14:18 +0100, Johannes Berg wrote: > >> I've been eyeing the multicast groups as well > > Of course, there are also *much* fewer mcast groups, so the saving isn't > nearly as big. But we still have some oddball code to register them all, > basically > > err = register_mc_group(); > if (err) > goto unregister_family; > > (since we have to register the family first, afaict) > > sometimes a few of those back to back, and it'd be nicer on the users if > that just went away and was > > family.mcast_groups = my_groups; > family.n_mcast_groups = ARRAY_SIZE(my_groups); > family.ops = my_ops; > family.n_ops = ARRAY_SIZE(my_ops); > return genl_register_family(&family); > > since nobody uses them dynamically anyway, afaict. See my other email: #define genl_register_family_with_ops_mcast(family, ops, groups) \ __genl_register_family(family, ops, ARRAY_SIZE(ops), groups, ARRAY_SIZE(groups)) you get the idea. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
