On Wed, May 29, 2013 at 02:03:29PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > I agree that the current situation is inconsistent. We have no way to > > know if the kernel validated the checksum or not from user-space, and > > I think this needs a fix. > > Good :-) > > > We can add a new NFQA_CFG_F_CSUM flag so user-space explicitly ask for > > assistance regarding checksumming from the kernel. If user-space tries > > to set that flag and the kernel does not support it, it will hit > > -EOPNOTSUPP. Thus, we can skip the feature retrieval thing. > > Yes, but this looks like abuse of the flag semantics to me. > Unless you mean that setting this feat flag should prompt the kernel > to explicitly call a valiation function in case skb_csum_unnecessary() > returns false? I mean exactly the current behaviour but forcing user-space to ask for it. So skb info flag regarding checksumming comes from kernel if explicitly requested from user-space. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
