Hi,
On Tue, 2012-11-27 at 12:51 +0100, Jan Engelhardt wrote:
> On Tuesday 2012-11-27 08:54, Eric Leblond wrote:
> >> index 630aee6..61d827a 100644
> >> --- a/output/Makefile.am
> >> +++ b/output/Makefile.am
> >> @@ -1,4 +1,4 @@
> >> -AM_CPPFLAGS = -I$(top_srcdir)/include
> >> +AM_CPPFLAGS = -I$(top_srcdir)/include ${LIBNETFILTER_ACCT_CFLAGS}
> >> AM_CFLAGS = ${regular_CFLAGS} ${LIBNETFILTER_LOG_CFLAGS} \
> >> ${LIBNETFILTER_CONNTRACK_CFLAGS}
> >
> >Good catch but on last line we use the other ${LIBNETFILTER*_CFLAGS} to
> >populate AM_CFLAGS. We should keep all variables at the same place. If
> >we follow your indication in the commit we should use AM_CPPFLAGS (I'm
> >agree with that).
>
> I can send another patch moving all the pkgconfig variables to
> CPPFLAGS.
Please do, I will push your two patches to the public tree once done.
BR,
--
Eric Leblond <eric@xxxxxxxxx>
Blog: https://home.regit.org/
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
