Re: [PATCH 2/2] build: resolve compile error due to missing nfacct CPPFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Tue, 2012-11-27 at 00:54 +0100, Jan Engelhardt wrote:
> Fixes this error:
> 
> make[3]: Entering directory "/home/jengelh/code/ulogd2/output"
>   CC       ulogd_output_XML.lo
> ulogd_output_XML.c:31:49: fatal error:
> libnetfilter_acct/libnetfilter_acct.h: No such file or directory
> 
> (Note that pkgconfig-provided cflags are actually cppflags, so
> I add ${LIBNETFILTER_ACCT_CFLAGS} to AM_CPPFLAGS.)
> 
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxxx>
> ---
>  output/Makefile.am |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/output/Makefile.am b/output/Makefile.am
> index 630aee6..61d827a 100644
> --- a/output/Makefile.am
> +++ b/output/Makefile.am
> @@ -1,4 +1,4 @@
> -AM_CPPFLAGS = -I$(top_srcdir)/include
> +AM_CPPFLAGS = -I$(top_srcdir)/include ${LIBNETFILTER_ACCT_CFLAGS}
>  AM_CFLAGS = ${regular_CFLAGS} ${LIBNETFILTER_LOG_CFLAGS} \
>  	    ${LIBNETFILTER_CONNTRACK_CFLAGS}

Good catch but on last line we use the other ${LIBNETFILTER*_CFLAGS} to
populate AM_CFLAGS. We should keep all variables at the same place. If
we follow your indication in the commit we should use AM_CPPFLAGS (I'm
agree with that).

BR,
-- 
Eric Leblond <eric@xxxxxxxxx>
Blog: https://home.regit.org/

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux