On Wednesday 2010-10-06 21:20, Sven-Ola Tuecke wrote: >> - There are pointless casts from/to void* > >That's for kernel-2.4: The target firmware uses that old kernel for Flash space >reasons. Only 1.75 Mb Flash and 8 Mb RAM. Even in 2.4, targinfo/matchinfo was already void*. >> - You should document what MAP66_lock is protecting. > >OK. They lock printk()s on SMP. Unnecessary without #DEBUG They should not overlap anyway because all of the strings use a newline already. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
