>> +static struct xt_led_info_internal *led_trigger_lookup(const char *name)
>> +{
>> + struct xt_led_info_internal *ledinternal;
>> +
>> + list_for_each_entry(ledinternal, &xt_led_triggers, list) {
>> + if (!strcmp(name, ledinternal->netfilter_led_trigger.name)) {
>> + mutex_unlock(&xt_led_mutex);
>
> This mutex_unlock looks out of place...
Oh well spotted, I forgot to take that out when moving the mutex out of this
function.
>> + ledinternal->trigger_id = kzalloc(strlen(ledinfo->id) + 1, GFP_KERNEL);
>
> kstrdup()?
Thanks for the suggestion, I will change this to use kstrdup().
Cheers,
Adam.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
