Re: [PATCH] Add refcounts to LED target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 2010-03-27 12:39, Adam Nielsen wrote:

>Add reference counting to the LED target so that multiple targets sharing the
>same trigger don't cause any problems.
>
>I have attached a patch based on nf-next-2.6.  It
>adds the reference counting that was discussed and fixes a bug where it
>referenced a null string once the original table/rule was destroyed.
>
>I've tested it and it works well for me, so subject to any feedback I believe
>it is ready to be included.

You need to protect the list_add/list_del from concurrent operation.

You need to check the return value of

ledinternal->trigger_id = kzalloc(strlen(ledinfo->id) + 1, GFP_KERNEL);
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux