Re: [PATCH v2] Add refcounts to LED target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 2010-03-28 03:25, Adam Nielsen wrote:

>Add reference counting to the LED target so that multiple targets sharing the
>same trigger don't cause any problems.

I also noticed one another thing: you don't increase the refcount while 
xt_led_mutex is held. That means it is theoretically possible that you 
do a lookup, then a destructor runs and frees the object, leading to 
++ledinternal->refcnt dereference an illegal ledinternal.

Overall, it works pretty much ok.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux