Hi Patrick, On Thu, 25 Sep 2008 06:46:54 +0200, Patrick McHardy <kaber@xxxxxxxxx> wrote: >Grant Coady wrote: >> Hi there, >> >> Given The LDD says: >> "note that the actual clock frequency is almost completely hidden from user >> space. The macro HZ always expands to 100 when user-space programs include >> param.h, and every counter reported to user space is converted accordingly. >> This applies to clock(3), times(2), and any related function." >> >> Why does ipt_recent expose jiffies to userspace when there seems to be no >> reliable method to determine the jiffies/second rate? Should not ipt_recent >> report in 10ms increments to match 'official jiffies'? (or why not epoch >> seconds?) I asked about this on lkml and received no response. > >It probably should use USER_HZ units. I just rewrote it, but kept >the old interface as it was for compatibility. > >> There's also another problem with ipt_recent misreporting oldest_pkt -- >> the number given is meaningless as it is not an offset to the oldest >> packet timestamp, nor does it indicate how many packets have been seen. >> There seems to be a problem when the table is full, I'm still collecting >> data on this. > >Indeed, its completely useless information. Actually I don't see >much use for anything in that proc file, but again, I kept it for >compatiblity. Twice you mention compatibility, should I plan on a replacement so the old code can be deprecated over time? The proc file is useful for external timebase process to remove stale IPs or inject IPs for service quota limiting. (At least, I can see a use for it that way). ... >Please base your patches on > >git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git Yeah, me git-challenged ;) got to figure out how to make two trees (this and kernel) play together? Got the git dribbling in at all of 3k/s (900k objects). Thanks, Grant. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
