Fabian Hugelshofer wrote:
Patrick McHardy wrote:
The module reference stuff (module_put/nf_ct_*_find_get etc)
is clearly superfluous, this runs in packet processing context
and shouldn't use module references but RCU.
Ok, I did what you said. You find the patch below. Is this what you
mean? If yes, I'll give it a try...
I applied the patch and did the test. The effect of removing unnecessary
locks reduced the CPU usage by one percent (packet rates verified to be
comparable this time).
It's up to you to decide if making the code less nice (IMHO) is worth
saving 1% CPU usage under rare circumstances.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
