On Jan 29 2008 16:31, Patrick McHardy wrote: > >> Anyway, please have this patch on top: >> >> The last u_int32_t should be ok as it stands. > > That fixes it, thanks. > > Do you have the typo-fixed version picked? The bogus one reads: @@ -210,7 +211,18 @@ static int htable_create(struct xt_hashlimit_info *minfo, int family) minfo->hinfo = hinfo; /* copy match config into hashtable config */ - memcpy(&hinfo->cfg, &minfo->cfg, sizeof(hinfo->cfg)); + hinfo->cfg.mode = minfo->cfg.mode; + hinfo->cfg.avg = minfo->cfg.avg; + hinfo->cfg.burst = hinfo->cfg.burst; + hinfo->cfg.max = hinfo->cfg.max; + hinfo->cfg.gc_interval = hinfo->cfg.gc_interval; + hinfo->cfg.expire = hinfo->cfg.expire; ... the corrected one I sent is: @@ -210,7 +211,18 @@ static int htable_create(struct xt_hashlimit_info *minfo, int family) minfo->hinfo = hinfo; /* copy match config into hashtable config */ - memcpy(&hinfo->cfg, &minfo->cfg, sizeof(hinfo->cfg)); + hinfo->cfg.mode = minfo->cfg.mode; + hinfo->cfg.avg = minfo->cfg.avg; + hinfo->cfg.burst = minfo->cfg.burst; + hinfo->cfg.max = minfo->cfg.max; + hinfo->cfg.gc_interval = minfo->cfg.gc_interval; + hinfo->cfg.expire = minfo->cfg.expire; ... e.g. always have minfo-> at the right side? Could you push the outstanding patches to Dave, or give me a git repository to sync against? thanks, Jan - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
