On Jan 29 2008 14:04, Patrick McHardy wrote:
>Subject: Re: [NETFILTER]: xt_hashlimit match, revision 1
>
> Jan Engelhardt wrote:
>> Hi,
>>
>> this patch was previously unmerged because it conflicted with Eric Dumazet's
>> changes. I now rediffed it; please apply.
>
> This adds a huge number of sparse warnings, please fix those up.
> I already fixed those in your other recent patches, but please
> make sure all patches you submit are sparse warning free.
Interestingly enough, I do not get these warnings.
Anyway, please have this patch on top:
The last u_int32_t should be ok as it stands.
commit 4af962ecb31dbd1588f6c8e50226666cc8147d77
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date: Tue Jan 29 16:24:47 2008 +0100
[NETFILTER]: xt_hashlimit: fix sparse warnings
Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index 68c1962..71572f9 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -464,7 +464,7 @@ static inline void rateinfo_recalc(struct dsthash_ent *dh, unsigned long now)
dh->rateinfo.prev = now;
}
-static inline u_int32_t maskl(u_int32_t a, unsigned int l)
+static inline __be32 maskl(__be32 a, unsigned int l)
{
return htonl(ntohl(a) & ~(~(u_int32_t)0 >> l));
}
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
