Subject: + lib-cmdlinec-declare-exported-symbols-immediately.patch added to -mm tree To: felipe.contreras@xxxxxxxxx,levex@xxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 18 Nov 2013 15:48:55 -0800 The patch titled Subject: lib/cmdline.c: declare exported symbols immediately has been added to the -mm tree. Its filename is lib-cmdlinec-declare-exported-symbols-immediately.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/lib-cmdlinec-declare-exported-symbols-immediately.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/lib-cmdlinec-declare-exported-symbols-immediately.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Felipe Contreras <felipe.contreras@xxxxxxxxx> Subject: lib/cmdline.c: declare exported symbols immediately WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable +EXPORT_SYMBOL(memparse); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable +EXPORT_SYMBOL(get_option); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable +EXPORT_SYMBOL(get_options); Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> Cc: Levente Kurusa <levex@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/cmdline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -puN lib/cmdline.c~lib-cmdlinec-declare-exported-symbols-immediately lib/cmdline.c --- a/lib/cmdline.c~lib-cmdlinec-declare-exported-symbols-immediately +++ a/lib/cmdline.c @@ -67,6 +67,7 @@ int get_option(char **str, int *pint) return 1; } +EXPORT_SYMBOL(get_option); /** * get_options - Parse a string into a list of integers @@ -112,6 +113,7 @@ char *get_options(const char *str, int n ints[0] = i - 1; return (char *)str; } +EXPORT_SYMBOL(get_options); /** * memparse - parse a string with mem suffixes into a number @@ -152,7 +154,4 @@ unsigned long long memparse(const char * return ret; } - EXPORT_SYMBOL(memparse); -EXPORT_SYMBOL(get_option); -EXPORT_SYMBOL(get_options); _ Patches currently in -mm which might be from felipe.contreras@xxxxxxxxx are origin.patch kstrtox-remove-redundant-cleanup.patch cmdline-fix-style-issues.patch lib-cmdlinec-declare-exported-symbols-immediately.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html