Subject: + cmdline-fix-style-issues.patch added to -mm tree
To: felipe.contreras@xxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 18 Nov 2013 15:47:40 -0800
The patch titled
Subject: lib/cmdline.c: fix style issues
has been added to the -mm tree. Its filename is
cmdline-fix-style-issues.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/cmdline-fix-style-issues.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/cmdline-fix-style-issues.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Felipe Contreras <felipe.contreras@xxxxxxxxx>
Subject: lib/cmdline.c: fix style issues
WARNING: space prohibited between function name and open parenthesis '('
+int get_option (char **str, int *pint)
WARNING: space prohibited between function name and open parenthesis '('
+ *pint = simple_strtol (cur, str, 0);
ERROR: trailing whitespace
+ $
WARNING: please, no spaces at the start of a line
+ $
WARNING: space prohibited between function name and open parenthesis '('
+ res = get_option ((char **)&str, ints + i);
Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/cmdline.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff -puN lib/cmdline.c~cmdline-fix-style-issues lib/cmdline.c
--- a/lib/cmdline.c~cmdline-fix-style-issues
+++ a/lib/cmdline.c
@@ -49,13 +49,13 @@ static int get_range(char **str, int *pi
* 3 - hyphen found to denote a range
*/
-int get_option (char **str, int *pint)
+int get_option(char **str, int *pint)
{
char *cur = *str;
if (!cur || !(*cur))
return 0;
- *pint = simple_strtol (cur, str, 0);
+ *pint = simple_strtol(cur, str, 0);
if (cur == *str)
return 0;
if (**str == ',') {
@@ -84,13 +84,13 @@ int get_option (char **str, int *pint)
* the parse to end (typically a null terminator, if @str is
* completely parseable).
*/
-
+
char *get_options(const char *str, int nints, int *ints)
{
int res, i = 1;
while (i < nints) {
- res = get_option ((char **)&str, ints + i);
+ res = get_option((char **)&str, ints + i);
if (res == 0)
break;
if (res == 3) {
@@ -153,7 +153,6 @@ unsigned long long memparse(const char *
return ret;
}
-
EXPORT_SYMBOL(memparse);
EXPORT_SYMBOL(get_option);
EXPORT_SYMBOL(get_options);
_
Patches currently in -mm which might be from felipe.contreras@xxxxxxxxx are
origin.patch
kstrtox-remove-redundant-cleanup.patch
cmdline-fix-style-issues.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
