On Mon, Aug 13, 2018 at 1:49 AM, Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> wrote: > * Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx> [2018-08-13 13:49:44]: > >> Hi Song, >> >> On 08/11/2018 01:42 PM, Song Liu wrote: >> > Do we really need this given we already have PATCH 4/6? >> > uprobe_regsiter() can be called >> > out of trace_uprobe, this patch won't catch all conflicts anyway. >> >> Right but it, at least, catch all conflicts happening via trace_uprobe. >> >> I don't mind in removing this patch but I would like to get an opinion of >> Oleg/Srikar/Steven/Masami. >> > > I would suggest to keep it, atleast it can ctah conflicts happening via > trace_uprobe. > Yeah, that makes sense. Reviewed-by: Song Liu <songliubraving@xxxxxx>