On Wed, Feb 28, 2018 at 6:03 PM, James Hogan <jhogan@xxxxxxxxxx> wrote: > On Wed, Feb 28, 2018 at 10:23:09AM +0800, Huacai Chen wrote: >> Hi, James, >> >> I really don't want send many patches in a seris. But in practise, my >> single patch in linux-mips usually be ignored (even they are very >> simple and well described).... > > Then please feel free to reply to the patch and ask if anybody has > feedback, stating how important the patch is for you, so it can be > prioritised. Resends as part of other series just adds to the noise. > >> >> For example: >> https://patchwork.linux-mips.org/patch/17723/ > > Yes, that one needs a proper look. > >> https://patchwork.linux-mips.org/patch/18587/ > > This one apparently knowingly breaks the feature on other platforms, so > can't really be applied as is. I think Matt Redfearn & I were thinking > his single IPI stuff could potentially be helpful there too. I think this does't break other platforms, because: 1, arch_trigger_cpumask_backtrace() will not be called in normal cases; 2, If arch_trigger_cpumask_backtrace() really be called, the old code also doesn't work (deadlock). > >> https://patchwork.linux-mips.org/patch/18682/ > > You sent that this morning so its hardly had time to be ignored, and I > had already spotted it on my phone and intended to apply it today. Also > I disagree that "Commit x breaks Loongson64 platforms, so fix it" counts > as well described, even if it is simple, and obvious (to me at least) > what you're talking about. > > E.g. a better description would along the lines of: > > Commit 7a407aa5e0d3 ("MIPS: Push ARCH_MIGHT_HAVE_PC_SERIO down to > platform level") moves the global MIPS ARCH_MIGHT_HAVE_PC_SERIO select > down to various platforms, but doesn't add it to Loongson64 platforms > which need it, so add the selects to these platforms too. I'll update my commit messages. > >> >> Anyway, thank you for your susggestions, I will rework other patches. > > Thank you. > > Cheers > James
