Re: MIPS: IP22: Fix binutils due to binutils 2.25 uselessnes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 16, 2016 at 02:22:16AM +0000, Maciej W. Rozycki wrote:

> On Thu, 15 Dec 2016, linux-mips@xxxxxxxxxxxxxx wrote:
> 
> > Fix build with binutils 2.25 by open coding the offending
> > 
> > 	dli $1, 0x9000000080000000
> > 
> > as
> > 
> > 	li	$1, 0x9000
> > 	dsll	$1, $1, 48
> > 
> > which is ugly be the only thing that will build on all binutils vintages.
> 
>  What about bit #31?  Shouldn't this be say:
> 
> 	lui	$1, 0x9000
> 	dsll	$1, $1, 16
> 	ori	$1, $1, 0x8000
> 	dsll	$1, $1, 16
> 
> ?

Argh, didn't spot the `8' in there.  64 bit constants are way too long :)

Thanks for reporting, will fix.

  Ralf




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux