On Mon, Jan 25, 2016 at 11:24:28PM +0100, Alban wrote: > > + if (IS_ENABLED(CONFIG_OF) && mips_machtype == ATH79_MACH_GENERIC_OF) { > > + return; > > + } > > + > > I think it would make more sense to move the whole implementation to > drivers/clk, otherwise we'll need to maintain two implementations. As a general rule, if there's a driver subsystem for something, I want code to go there, not arch/mips. Ralf