On Sat, 23 Jan 2016 23:17:19 +0300 Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote: > Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx> > Cc: Gabor Juhos <juhosg@xxxxxxxxxxx> > Cc: Alban Bedel <albeu@xxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxx > --- > arch/mips/ath79/clock.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c > index eb5117c..8a287bf 100644 > --- a/arch/mips/ath79/clock.c > +++ b/arch/mips/ath79/clock.c > @@ -24,6 +24,7 @@ > #include <asm/mach-ath79/ath79.h> > #include <asm/mach-ath79/ar71xx_regs.h> > #include "common.h" > +#include "machtypes.h" > > #define AR71XX_BASE_FREQ 40000000 > #define AR724X_BASE_FREQ 5000000 > @@ -133,6 +134,10 @@ static void __init ar913x_clocks_init(void) > u32 freq; > u32 div; > > + if (IS_ENABLED(CONFIG_OF) && mips_machtype == ATH79_MACH_GENERIC_OF) { > + return; > + } > + I think it would make more sense to move the whole implementation to drivers/clk, otherwise we'll need to maintain two implementations. Alban