On Thu, 21 Jan 2016 12:59:04 +0300
Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
> At the moment ar913x_clocks_init() does not use extosc node at all,
> the reference clock rate is hardcoded inside arch/mips/ath79/clock.c
>
> #define AR913X_BASE_FREQ 5000000
>
> ...
>
> static void __init ar913x_clocks_init(void)
> {
> ref_rate = AR913X_BASE_FREQ;
>
> ...
>
> ath79_add_sys_clkdev("ref", ref_rate);
>
> Also please see the commits 'MIPS: ath79: Fix the ar913x reference clock rate'
> and 'MIPS: ath79: Fix the ar724x clock calculation' in Alban Bedel's
> github ath79 branch https://github.com/AlbanBedel/linux/tree/ath79
Yes, the reference clock definition is not yet used by the code, but
the binding define it as required. This is because a proper
implementation would need the reference clock rate.
It would be better to fix the code to get rid of the hard coded rates
when using DT. I haven't done so yet because I wanted to first get DT
support without too many changes, but that's on the TODO list along with
moving to drivers/clk.
Alban
