On Tue, 2 Jun 2015, Ralf Baechle wrote: > Maciej, I think the variables sr, mask, fcsr, fcsr0 and fcsr1 should > become unsigned ints; they all represent 32 bit CPU registers. Also > read_32bit_cp1_register() return a signed int. A signed int probably > would make more sense here. The choice of types for `sr', `fcsr', etc. is I think mainly cosmetic, I considered it while implementing `cpu_set_fpu_fcsr_mask', but decided to follow prior art for consistency. Cleaning up the whole of cpu-probe.c WRT these types seems reasonable to me. Again I think `read_32bit_cp1_register' returns a signed int for consistency with `__read_32bit_c0_register' that does too. Perhaps an unsigned int would do for `read_32bit_cp1_register' and then two variants of `__read_32bit_c0_register', signed and unsigned, used on a case by case basis. Maciej
