Hello. On 12/08/2013 09:10 PM, Hauke Mehrtens wrote:
+#ifdef CONFIG_BCMA_HOST_SOC chip->to_irq = bcma_gpio_to_irq; +#endif chip->ngpio = 16;
Hi,
Should this not be
if (IS_ENABLED(CONFIG_BCMA_HOST_SOC)) chip->to_irq = bcma_gpio_to_irq;
I can't find a proper documentation about that. It's definitely nicer to use #if IS_ENABLED(FOO) instead of #if defined(FOO) || defined(FOO_MODULE)
But are we supposed to use it also for a simple #if defined(FOO) ?
I tried to Google about this but found only some minor flame-wars ;)
Is that documented anywhere?
The commit message has the relevant info ...
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=2a11c8ea20bf850b3a2c60db8c2e7497d28aba99
I read this and as far as I understand that when CONFIG_BCMA_HOST_SOC is bool and not tristate "#ifdef CONFIG_BCMA_HOST_SOC" and "#if IS_ENABLED(CONFIG_BCMA_HOST_SOC)" will have the same effect?
You can also use IS_BUILTIN(CONFIG_BCMA_HOST_SOC) to avoid unneeded test for the modular case.
Hauke
WBR, Sergei
