On 11/29/2013 10:16 PM, John Crispin wrote: > On 29/11/13 21:53, Rafał Miłecki wrote: >> 2013/11/29 John Crispin<john@xxxxxxxxxxx>: >>> On 29/11/13 20:12, Rafał Miłecki wrote: >>>> >>>> +#ifdef CONFIG_BCMA_HOST_SOC >>>> chip->to_irq = bcma_gpio_to_irq; >>>> +#endif >>>> chip->ngpio = 16; >>> >>> >>> >>> Hi, >>> >>> Should this not be >>> >>> if (IS_ENABLED(CONFIG_BCMA_HOST_SOC)) >>> chip->to_irq = bcma_gpio_to_irq; >> >> I can't find a proper documentation about that. It's definitely nicer >> to use >> #if IS_ENABLED(FOO) >> instead of >> #if defined(FOO) || defined(FOO_MODULE) >> >> But are we supposed to use it also for a simple >> #if defined(FOO) >> ? >> >> I tried to Google about this but found only some minor flame-wars ;) >> >> Is that documented anywhere? >> > > > The commit message has the relevant info ... > > http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=2a11c8ea20bf850b3a2c60db8c2e7497d28aba99 I read this and as far as I understand that when CONFIG_BCMA_HOST_SOC is bool and not tristate "#ifdef CONFIG_BCMA_HOST_SOC" and "#if IS_ENABLED(CONFIG_BCMA_HOST_SOC)" will have the same effect? @Rafał Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx> for the "bcma: gpio: add own IRQ domain" patch. Hauke
