2013/11/29 John Crispin <john@xxxxxxxxxxx>: > On 29/11/13 20:12, Rafał Miłecki wrote: >> >> +#ifdef CONFIG_BCMA_HOST_SOC >> chip->to_irq = bcma_gpio_to_irq; >> +#endif >> chip->ngpio = 16; > > > > Hi, > > Should this not be > > if (IS_ENABLED(CONFIG_BCMA_HOST_SOC)) > chip->to_irq = bcma_gpio_to_irq; I can't find a proper documentation about that. It's definitely nicer to use #if IS_ENABLED(FOO) instead of #if defined(FOO) || defined(FOO_MODULE) But are we supposed to use it also for a simple #if defined(FOO) ? I tried to Google about this but found only some minor flame-wars ;) Is that documented anywhere? -- Rafał
