On Thu, May 2, 2013 at 11:04 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > On Thu, 2 May 2013, David Daney wrote: > >> From: David Daney <david.daney@xxxxxxxxxx> >> >> As noted by Thomas Gleixner: >> >> commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did >> not realize that MIPS wants to invoke the wait instructions with >> interrupts enabled. >> >> Instead of enabling interrupts in arch_cpu_idle() as Thomas' initial >> patch does, we follow Linus' suggestion of doing it in the assembly >> code to prevent the compiler from rearranging things. > > Yeah, that looks way more sane. In a first quick test I can also confirm that it seems to work (as an alternative to the other fix). Jonas
