Hello. On 30-04-2012 15:33, John Crispin wrote:
Due to a wrongly placed bracket,
I don't see a bracket in old code at all.
the irq modules were not properly reset on boot.
Signed-off-by: John Crispin<blogic@xxxxxxxxxxx> --- arch/mips/lantiq/irq.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c index d673731..b6b1c72 100644 --- a/arch/mips/lantiq/irq.c +++ b/arch/mips/lantiq/irq.c @@ -271,12 +271,13 @@ void __init arch_init_irq(void) if (!ltq_eiu_membase) panic("Failed to remap eiu memory"); - /* make sure all irqs are turned off by default */ - for (i = 0; i< 5; i++) + /* turn off all irqs by default */ + for (i = 0; i< 5; i++) { + /* make sure all irqs are turned off by default */ ltq_icu_w32(0, LTQ_ICU_IM0_IER + (i * LTQ_ICU_OFFSET)); - - /* clear all possibly pending interrupts */ - ltq_icu_w32(~0, LTQ_ICU_IM0_ISR + (i * LTQ_ICU_OFFSET)); + /* clear all possibly pending interrupts */ + ltq_icu_w32(~0, LTQ_ICU_IM0_ISR + (i * LTQ_ICU_OFFSET)); + } mips_cpu_irq_init();
WBR, Sergei