Re: [PATCH 2/2] MIPS: Optimize TLB handlers for Octeon CPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19 January 2011 20:41, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:
> On 01/19/2011 11:35 AM, Jonas Gorski wrote:
>>
>> On 28/12/2010, David Daney<ddaney@xxxxxxxxxxxxxxxxxx> Âwrote:
>>>
>>> +#if defined(CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE)&& Â\
>>> + Â ÂCONFIG_CAVIUM_OCTEON_CVMSEG_SIZE> Â0
>>> (...)
>>> +#else
>>> +static bool scratchpad_available(void)
>>> +{
>>> + Â Â Â return false;
>>> +}
>>> +static int scratchpad_offset(int i)
>>> +{
>>> + Â Â Â BUG();
>>> +}
>>> +#endif
>>
>> This seems to have broken the build for any non-octeon mips build:
>>
>> Â CC Â Â Âarch/mips/mm/tlbex.o
>> cc1: warnings being treated as errors
>> arch/mips/mm/tlbex.c: In function 'scratchpad_offset':
>> arch/mips/mm/tlbex.c:112: error: no return statement in function
>> returning non-void
>>
>
> Can you tell me which version of GCC you are using?
>
> I tested it with gcc-4.5.x, BUG() may have problems if builtin_unreachable
> is not available.

That's probably it, It's a 4.3.3 (with code sourcery extensions, the
OpenWrt default one).

Jonas



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux