On Tue, Jan 26, 2010 at 4:58 PM, Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:
> On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote:
>> Hi,
>>
>> On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:
>> > Changes from v1 (feedbacks from Ralf):
>> >
>> > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL
>> >
>> > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the
>>
>> Not every chip has a standard 16550, unfortunately. I liked your
>> first iteration better:
>> DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another
>> (invisible)
>> config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550
>> for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported
>> chips).
>>
>
> Yes, It will be not convenient for a new serial port debugging support
> with the current modification, for example, if you add UARTXXXX, we need
> to select it for the new board and also add it under the "depends" of
> DEBUG_ZBOOT. how about this?
[...]
Fine with me. I'll resend an updated Alchemy zboot debug patch once
this has been applied.
Thank you!
Manuel Lauss
