Hi, On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote: > Changes from v1 (feedbacks from Ralf): > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the Not every chip has a standard 16550, unfortunately. I liked your first iteration better: DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another (invisible) config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550 for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported chips). > obj-$(CONFIG_DEBUG_ZBOOT_UART16550) into just obj-$(CONFIG_DEBUG_ZBOOT) and > no ifdef. The last hunk does something else: > -obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT) += $(obj)/uart-16550.o Manuel