On Tue, Jan 26, 2010 at 11:02:34PM +0800, Wu Zhangjin wrote: > There was a __weak define as __attribute__((weak)) there, this patch > just use it to simplify the weak annotation. Nice cleanup; I've made it bulletproof by including <linux/compiler.h> which defines __weak. Queued for 2.6.34. Ralf