On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote: > On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote: > > Hi, > > > > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote: > > > Changes from v1 (feedbacks from Ralf): > > > > > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL > > > > > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the > > > > Not every chip has a standard 16550, unfortunately. I liked your > > first iteration better: > > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another > > (invisible) > > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550 > > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported > > chips). > > > > Yes, It will be not convenient for a new serial port debugging support > with the current modification, for example, if you add UARTXXXX, we need > to select it for the new board and also add it under the "depends" of > DEBUG_ZBOOT. how about this? > > diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug > index 5e556f7..6fccbf0 100644 > --- a/arch/mips/Kconfig.debug > +++ b/arch/mips/Kconfig.debug > @@ -104,7 +104,7 @@ config RUNTIME_DEBUG > > config DEBUG_ZBOOT > bool "Enable compressed kernel support debugging" > - depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550 > + depends on DEBUG_KERNEL > oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it should be: depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT > and we keep the old: > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > endif > > If a new serial port is needed, we just need to add the following lines > to arch/mips/Kconfig > > config SYS_SUPPORTS_ZBOOT_UARTXXX > bool > select SYS_SUPPORTS_ZBOOT > > config MACH_XXXX > [...] > select SYS_SUPPORTS_ZBOOT_UARTXXX > [...] > > and in arch/mips/boot/compressed/Makfefile > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o > endif > > and also a new arch/mips/boot/compressed/uar-xxx.c is needed. > > If this is okay, I will send a new revision asap. > > Regards, > Wu Zhangjin
